改进单元测试

This commit is contained in:
thinkphp
2016-08-23 18:35:41 +08:00
parent 24a5ed1cb9
commit cf5386de70
2 changed files with 5 additions and 2 deletions

View File

@@ -236,6 +236,9 @@ class Url
{
foreach ($rule as $item) {
list($url, $pattern, $domain) = $item;
if (empty($pattern)) {
return [$url, $domain];
}
foreach ($pattern as $key => $val) {
if (isset($vars[$key])) {
$url = str_replace(['[:' . $key . ']', '<' . $key . '?>', ':' . $key . '', '<' . $key . '>'], $vars[$key], $url);

View File

@@ -57,7 +57,7 @@ class urlTest extends \PHPUnit_Framework_TestCase
public function testBuildMethod()
{
Route::get('blog/:id', '\app\index\controller\blog@read');
$this->assertEquals('/blog/10.html', Url::build('\app\index\controller\blog\read', 'id=10', 'html'));
$this->assertEquals('/blog/10.html', Url::build('[\app\index\controller\blog@read]', 'id=10', 'html'));
}
public function testBuildRoute()
@@ -71,7 +71,7 @@ class urlTest extends \PHPUnit_Framework_TestCase
public function testBuildNameRoute()
{
Route::get(['name', 'blog/:id'], 'index/blog');
$this->assertEquals(['blog/:id', ['id' => 1], null], Route::name('name'));
$this->assertEquals(['blog/:id', [['id' => 1], null]], Route::name('name'));
Config::set('url_html_suffix', 'shtml');
$this->assertEquals('/blog/10.shtml', Url::build('name?id=10'));
}